Fix testCancelOnExpiry#146015
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Apr 10, 2026
Merged
Conversation
dnhatn
added
v9.4.1
v9.3.4
v9.2.9
v8.19.15
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Apr 10, 2026
The test failed because it used a small keep_alive on submission, leading to cases where data-node drivers were slow to start and the query was cancelled before any driver had started. This PR modifies the test to check for cancellation in two steps: submit with a large keep_alive and wait until at least one data-node driver has started, then adjust the keep_alive to a much smaller interval and expect cancellation to happen. Closes elastic#145502
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test failed because it used a small keep_alive on submission, leading to cases where data-node drivers were slow to start and the query was cancelled before any driver had started. This PR modifies the test to check for cancellation in two steps: submit with a large keep_alive and wait until at least one data-node driver has started, then adjust the keep_alive to a much smaller interval and expect cancellation to happen.
Closes #145502